virajjasani commented on code in PR #5893:
URL: https://github.com/apache/hadoop/pull/5893#discussion_r1320971978
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingLruEviction.java:
##########
@@ -175,7 +177,9 @@ public void testSeeksWithLruEviction() throws Throwable {
LOG.info("IO stats: {}", ioStats);
verifyStatisticGaugeValue(ioStats, STREAM_READ_BLOCKS_IN_FILE_CACHE, 0);
assertThatStatisticCounter(ioStats,
- STREAM_EVICT_BLOCKS_FROM_FILE_CACHE).isGreaterThanOrEqualTo(5);
+ STREAM_EVICT_BLOCKS_FROM_FILE_CACHE).isGreaterThanOrEqualTo(4);
Review Comment:
sounds good, since the eventually() throws last exception (which comes from
assertj library, they are not taking any error msg as argument), let me add
comments on this.
we don't see flakiness as such but 4 is good enough based on multiple rounds
of tests that i did last week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
