[
https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763634#comment-17763634
]
ASF GitHub Bot commented on HADOOP-18487:
-----------------------------------------
steveloughran commented on code in PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#discussion_r1321307490
##########
hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml:
##########
@@ -451,8 +451,7 @@
</Match>
<Match>
- <Class name="org.apache.hadoop.ipc.ProtobufHelper" />
- <Method name="getFixedByteString" />
+ <Class name="org.apache.hadoop.ipc.internal.ShadedProtobufHelper" />
Review Comment:
yes.
> protobuf-2.5.0 dependencies => provided
> ---------------------------------------
>
> Key: HADOOP-18487
> URL: https://issues.apache.org/jira/browse/HADOOP-18487
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, ipc
> Affects Versions: 3.3.4
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> uses of protobuf 2.5 and RpcEnginej have been deprecated since 3.3.0 in
> HADOOP-17046
> while still keeping those files around (for a long time...), how about we
> make the protobuf 2.5.0 export off hadoop common and hadoop-hdfs *provided*,
> rather than *compile*
> that way, if apps want it for their own apis, they have to explicitly ask for
> it, but at least our own scans don't break.
> i have no idea what will happen to the rest of the stack at this point, it
> will be "interesting" to see
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
