[ 
https://issues.apache.org/jira/browse/HADOOP-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765424#comment-17765424
 ] 

ASF GitHub Bot commented on HADOOP-18891:
-----------------------------------------

AuthurWang2009 commented on PR #6070:
URL: https://github.com/apache/hadoop/pull/6070#issuecomment-1720409634

   Due to my mistakes, I incorrectly commit my pull requests to branch, but not 
trunk.
   
   Compared to the previous commit, I have made the following improvements:
   1、import ordering
   2、javadocs, and indentation policy
   3、some comment to explain how the code runs
   
   Thanks for [steveloughran](https://github.com/steveloughran) for your 
reviews.




> hadoop distcp needs support to filter by file/directory attribute
> -----------------------------------------------------------------
>
>                 Key: HADOOP-18891
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18891
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: tools/distcp
>    Affects Versions: 3.3.6
>         Environment: hadoop3.3.6
>            Reporter: Authur Wang
>            Priority: Major
>              Labels: pull-request-available
>
> In some circumstances, we need to filter file/directory by file/directroy. 
> For example, we need to filter out them by file modified time, isDir attrs, 
> etc.
> So, *should we introduce a new method  public boolean 
> shouldCopy(CopyListingFileStatus fileStatus)* ? 
> by this approach, we can introduce a more fluent way to do things than  
> public abstract boolean shouldCopy(Path path).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to