Hexiaoqiao commented on code in PR #6029:
URL: https://github.com/apache/hadoop/pull/6029#discussion_r1326940963
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataSetLockManager.java:
##########
@@ -256,7 +256,7 @@ private synchronized void putThreadName(String thread) {
threadCountMap.putIfAbsent(thread, new TrackLog(thread));
}
- public void lockLeakCheck() {
+ public synchronized void lockLeakCheck() {
Review Comment:
@LiuGuH Thanks for your contribution here. IIRC, this is only invoked when
DataNode instance shutdown, and no more concurrent issue generally. So do you
meet some issues here? Theoretically, I think it is better to add
`synchronized`. Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
