zhengchenyu commented on PR #6042:
URL: https://github.com/apache/hadoop/pull/6042#issuecomment-1726668134

   @ayushtkn Sorry this is my fault. I thought that changing the default value 
is not a serious behavior. I will fix the UT.
   BTW, can we trigger the test4tests when  show 'The patch doesn't appear to 
include any new or modified tests.'? 
   
   
   > Mostly we shouldn't change the default values but fix the cause.
   
   I think we should change the default value. For now, when 
og4j.appender.{APPENDER}.MaxFileSize is 0, we could only see the lastest log. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to