simbadzina commented on code in PR #6043:
URL: https://github.com/apache/hadoop/pull/6043#discussion_r1332537239
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -2945,6 +2945,9 @@ private void processRpcRequest(RpcRequestHeaderProto
header,
}
}
} catch (IOException ioe) {
+ if (ioe instanceof RetriableException) {
Review Comment:
Consider putting a try catch blocked around receiveRequestState. This makes
it easier to see where the exception is coming from, instead of checking the
type of exception later. So something like
```java
try {
stateId = alignmentContext.receiveRequestState(header, getMaxIdleTime());
} catch (RetriableException re) {
rpcMetrics.incrRcRejectedByObserverCalls();
throw re;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
