[ https://issues.apache.org/jira/browse/HADOOP-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767473#comment-17767473 ]
ASF GitHub Bot commented on HADOOP-18829: ----------------------------------------- mehakmeet commented on code in PR #5893: URL: https://github.com/apache/hadoop/pull/5893#discussion_r1332719297 ########## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingLruEviction.java: ########## @@ -175,7 +177,9 @@ public void testSeeksWithLruEviction() throws Throwable { LOG.info("IO stats: {}", ioStats); verifyStatisticGaugeValue(ioStats, STREAM_READ_BLOCKS_IN_FILE_CACHE, 0); assertThatStatisticCounter(ioStats, - STREAM_EVICT_BLOCKS_FROM_FILE_CACHE).isGreaterThanOrEqualTo(5); + STREAM_EVICT_BLOCKS_FROM_FILE_CACHE).isGreaterThanOrEqualTo(4); Review Comment: Sure, let's not worry about it then, I was thinking more of adding the error message to the assertion itself rather than the eventually() block. It's always tricky with multi-threaded tests with falkiness. > s3a prefetch LRU cache eviction metric > -------------------------------------- > > Key: HADOOP-18829 > URL: https://issues.apache.org/jira/browse/HADOOP-18829 > Project: Hadoop Common > Issue Type: Sub-task > Reporter: Viraj Jasani > Assignee: Viraj Jasani > Priority: Major > Labels: pull-request-available > > Follow-up from HADOOP-18291: > Add new IO statistics metric to capture s3a prefetch LRU cache eviction. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org