ferdelyi commented on code in PR #6027:
URL: https://github.com/apache/hadoop/pull/6027#discussion_r1334511785
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMStoreCommands.java:
##########
@@ -101,6 +102,16 @@ public void testFormatConfStoreCmdForZK() throws Exception
{
}
}
+ @Test
+ public void testSSLEnabledConfiguration() {
+ //Test if we can enable SSL/TLS for the ZK Curator Client in YARN.
+ Configuration conf = new Configuration();
+ conf.set(YarnConfiguration.RM_ZK_CLIENT_SSL_ENABLED,
Boolean.TRUE.toString());
+
+ assertEquals("The " + YarnConfiguration.RM_ZK_CLIENT_SSL_ENABLED + " value
should be true.",
+ conf.get(YarnConfiguration.RM_ZK_CLIENT_SSL_ENABLED),
Boolean.TRUE.toString());
+ }
Review Comment:
Thank you Szilard for the review!
"The ZKCuratorManager is started with SSL disabled by default. " case is
implicitly covered in the already existing TestLeaderElectorService.java, as it
uses Curator.
Testing the SSL case will be more tricky due to CURATOR-658 "Add Support for
TLS-enabled TestingZooKeeperMain" won't be fixed, but it seems there is a way
by using ZooKeeperServerEmbeddedAdapter, which I need to explore how to
implement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
