slfan1989 commented on code in PR #6083:
URL: https://github.com/apache/hadoop/pull/6083#discussion_r1337380994
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
##########
@@ -761,7 +761,7 @@ public AppsInfo getApps(HttpServletRequest hsr, String
stateQuery,
});
if (apps.getApps().isEmpty()) {
- return null;
+ return apps;
Review Comment:
Thank you very much for your help in reviewing the code! I was doing the
integration test of YARN Federation recently and accidentally mixed some code
into YARN-8862. I will fix this part of the code.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestRouterWebServicesREST.java:
##########
@@ -373,6 +373,8 @@ public void testClusterInfoXML() throws Exception {
assertEquals(
rmResponse.getRMVersion(),
routerResponse.getRMVersion());
+
+ Thread.sleep(10000000);
Review Comment:
I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
