goiri commented on code in PR #6145:
URL: https://github.com/apache/hadoop/pull/6145#discussion_r1346249636
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NodeLabelsPage.java:
##########
@@ -33,10 +33,14 @@ public class NodeLabelsPage extends RouterView {
protected void preHead(Hamlet.HTML<__> html) {
commonPreHead(html);
String type = $(NODE_SC);
+ String nodeLabel = $(NODE_LABEL);
String title = "Node labels of the cluster";
- if (type != null && !type.isEmpty()) {
+ if(nodeLabel != null && !nodeLabel.isEmpty()){
Review Comment:
Space
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NodesPage.java:
##########
@@ -32,8 +33,11 @@ class NodesPage extends RouterView {
protected void preHead(Page.HTML<__> html) {
commonPreHead(html);
String type = $(NODE_SC);
+ String state = $(NODE_STATE);
String title = "Nodes of the cluster";
- if (type != null && !type.isEmpty()) {
+ if(state != null && !state.isEmpty()){
Review Comment:
Space and stringbuilder
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NodeLabelsPage.java:
##########
@@ -21,7 +21,7 @@
import org.apache.hadoop.yarn.webapp.SubView;
import org.apache.hadoop.yarn.webapp.hamlet2.Hamlet;
-import static org.apache.hadoop.yarn.webapp.YarnWebParams.NODE_SC;
+import static org.apache.hadoop.yarn.webapp.YarnWebParams.*;
Review Comment:
Avoid
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NodesBlock.java:
##########
@@ -39,7 +40,7 @@
import java.util.Date;
-import static org.apache.hadoop.yarn.webapp.YarnWebParams.NODE_SC;
+import static org.apache.hadoop.yarn.webapp.YarnWebParams.*;
Review Comment:
Avoid
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/NodeLabelsPage.java:
##########
@@ -33,10 +33,14 @@ public class NodeLabelsPage extends RouterView {
protected void preHead(Hamlet.HTML<__> html) {
commonPreHead(html);
String type = $(NODE_SC);
+ String nodeLabel = $(NODE_LABEL);
String title = "Node labels of the cluster";
Review Comment:
Should we use a StringBuilder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
