goiri commented on code in PR #6016:
URL: https://github.com/apache/hadoop/pull/6016#discussion_r1346292836
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##########
@@ -194,12 +205,19 @@ public class ZookeeperFederationStateStore implements
FederationStateStore {
private int maxAppsInStateStore;
/** Directory to store the delegation token data. **/
+ private Map<Integer, String> routerAppRootHierarchies;
private String routerRMDTSecretManagerRoot;
private String routerRMDTMasterKeysRootPath;
private String routerRMDelegationTokensRootPath;
private String routerRMSequenceNumberPath;
private String routerRMMasterKeyIdPath;
+ private int appIdNodeSplitIndex = 0;
+ private final int HIERARCHIES_LEVEL = 4;
Review Comment:
```
21: Name 'HIERARCHIES_LEVEL' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[MemberName]
```
I think you need to make it static.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##########
@@ -194,12 +205,19 @@ public class ZookeeperFederationStateStore implements
FederationStateStore {
private int maxAppsInStateStore;
/** Directory to store the delegation token data. **/
+ private Map<Integer, String> routerAppRootHierarchies;
private String routerRMDTSecretManagerRoot;
private String routerRMDTMasterKeysRootPath;
private String routerRMDelegationTokensRootPath;
private String routerRMSequenceNumberPath;
private String routerRMMasterKeyIdPath;
+ private int appIdNodeSplitIndex = 0;
+ private final int HIERARCHIES_LEVEL = 4;
Review Comment:
Add a comment on what the four are. Probably referring to the hierarchy from
before but shorter.
`APPLICATION\HIERARCHIES\ID\APP_ID`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
