xinglin commented on code in PR #6146:
URL: https://github.com/apache/hadoop/pull/6146#discussion_r1349455374
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -587,10 +601,10 @@ void logSlowRpcCalls(String methodName, Call call,
final double threeSigma = rpcMetrics.getProcessingMean() +
(rpcMetrics.getProcessingStdDev() * deviation);
- long processingTime =
- details.get(Timing.PROCESSING, rpcMetrics.getMetricsTimeUnit());
+ long processingTime = details.get(Timing.PROCESSING,
rpcMetrics.getMetricsTimeUnit());
Review Comment:
`rpcMetrics.getMetricsTimeUnit` is not necessary always in Millis. We need
to convert getLogSlowRPCThresholdMs() into the same TimeUnit before we can do
the comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
