slfan1989 commented on code in PR #6154:
URL: https://github.com/apache/hadoop/pull/6154#discussion_r1349601908
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -1015,6 +1015,10 @@ private void startCommonServices(Configuration conf)
throws IOException {
LOG.info(getRole() + " service RPC up at: "
+ rpcServer.getServiceRpcAddress());
}
+ if (rpcServer.getLifelineRpcAddress() != null) {
+ LOG.info(getRole() + " lifeline RPC up at: "
Review Comment:
@haiyang1987 Thank you for your contribution! For newly added logs, should
we use {} instead of splicing?
```
LOG.info("{} lifeline RPC up at: {}.", getRole(),
rpcServer.getLifelineRpcAddress());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
