steveloughran commented on code in PR #6141:
URL: https://github.com/apache/hadoop/pull/6141#discussion_r1350383710
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestDirectoryMarkerListing.java:
##########
@@ -610,15 +611,18 @@ private void put(final String key, final String content)
throws Exception {
RequestBody.fromString(content)));
}
/**
- * Delete an object.
+ * Delete an object; exceptions are swallowed.
* @param key key
- * @param content string
*/
private void deleteObject(final String key) throws Exception {
- exec("DELETE " + key, () -> {
- s3client.deleteObject(b -> b.bucket(bucket).key(key));
- return "deleted " + key;
- });
+ try {
+ exec("DELETE " + key, () -> {
+ s3client.deleteObject(b -> b.bucket(bucket).key(key));
+ return "deleted " + key;
+ });
+ } catch (IOException ignored) {
Review Comment:
google gcs raises 404 if the object doesn't exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
