[
https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773380#comment-17773380
]
ASF GitHub Bot commented on HADOOP-18487:
-----------------------------------------
steveloughran commented on PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1753244196
test failure seems unrelated.
style
```
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/GenericRefreshProtocolClientSideTranslatorPB.java:62:
.setIdentifier(identifier): '.' has incorrect indentation level 6,
expected level should be 8. [Indentation]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/GenericRefreshProtocolClientSideTranslatorPB.java:63:
.addAllArgs(argList): '.' has incorrect indentation level 6, expected
level should be 8. [Indentation]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/GenericRefreshProtocolClientSideTranslatorPB.java:64:
.build();: '.' has incorrect indentation level 6, expected level should
be 8. [Indentation]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protocolPB/GenericRefreshProtocolClientSideTranslatorPB.java:66:
GenericRefreshResponseCollectionProto resp = ipc(() ->
rpcProxy.refresh(NULL_CONTROLLER, request));: Line is longer than 100
characters (found 103). [LineLength]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/protocolPB/GetUserMappingsProtocolClientSideTranslatorPB.java:27:import
org.apache.hadoop.ipc.internal.ShadedProtobufHelper;:8: Unused import -
org.apache.hadoop.ipc.internal.ShadedProtobufHelper. [UnusedImports]
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/protocolPB/GetUserMappingsProtocolClientSideTranslatorPB.java:33:import
org.apache.hadoop.thirdparty.protobuf.ServiceException;:8: Unused import -
org.apache.hadoop.thirdparty.protobuf.ServiceException. [UnusedImports]
./hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java:243:
ipc(() -> rpcProxy.shutdownDatanode(NULL_CONTROLLER, request));: 'method
def' child has incorrect indentation level 6, expected level should be 4.
[Indentation]
```
javadocs
```
[ERROR] in your comments are valid in HTML5, and remove the -html4 option.
[ERROR]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-4996/ubuntu-focal/src/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufHelper.java:39:
error: unknown tag: Deprecated:
[ERROR] * @Deprecated: hadoop code MUST use {@link ShadedProtobufHelper}.
```
maybe its the :
> protobuf-2.5.0 dependencies => provided
> ---------------------------------------
>
> Key: HADOOP-18487
> URL: https://issues.apache.org/jira/browse/HADOOP-18487
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, ipc
> Affects Versions: 3.3.4
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> uses of protobuf 2.5 and RpcEnginej have been deprecated since 3.3.0 in
> HADOOP-17046
> while still keeping those files around (for a long time...), how about we
> make the protobuf 2.5.0 export off hadoop common and hadoop-hdfs *provided*,
> rather than *compile*
> that way, if apps want it for their own apis, they have to explicitly ask for
> it, but at least our own scans don't break.
> i have no idea what will happen to the rest of the stack at this point, it
> will be "interesting" to see
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
