steveloughran commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1753482819
with this PR * all s3 select code is stripped * all imports of its classes are gone * docs say this * path capability returns false * openFile with select options raise UnsupportedOperation + test * s3guard select command fails, with new test Retained 1. `SelectConstants` in case used externally 2. `org.apache.hadoop.fs.s3a.select.BlockingEnumeration` in case its useful in future I have a concern about retention #2; it uses the unshaded package `org.reactivestreams` hidden away in bundle.jar. I understand why it is unshaded -it's a public API- but its not good to build against someone's classes in an unrelated jar...wildfly springs to mind as an example we may want to cut it -we can always add a ref in the package docs to say its' been cut and which git commit to go to so as to find it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
