[
https://issues.apache.org/jira/browse/HADOOP-18915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774416#comment-17774416
]
Steve Loughran commented on HADOOP-18915:
-----------------------------------------
actually there's more than the patch
One of the options (connection.request.timeout) uses getTimeDuration() and lets
you use suffixes line ns. m, h etc, which you can see when it complains about
no unit provided.
Configuration.deprecation: No unit for fs.s3a.connection.request.timeout(0)
assuming SECONDS
they should all be using it. now, fun thing. that connection.request timeout
(default to 0 and is max time of any request) is seconds.
but it's 0 because nothing should really be setting it; it'll break long GET
requests.
proposed: move to time duration everywhere, set millis as the default. update
core-defaul.xml
> HTTP timeouts are not set correctly
> -----------------------------------
>
> Key: HADOOP-18915
> URL: https://issues.apache.org/jira/browse/HADOOP-18915
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Ahmar Suhail
> Assignee: Steve Loughran
> Priority: Major
>
> In the client config builders, when [setting
> timeouts|https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSClientConfig.java#L120],
> it uses Duration.ofSeconds(), configs all use milliseconds so this needs to
> be updated to Duration.ofMillis().
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
