[
https://issues.apache.org/jira/browse/HADOOP-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774528#comment-17774528
]
ASF GitHub Bot commented on HADOOP-18935:
-----------------------------------------
steveloughran opened a new pull request, #6177:
URL: https://github.com/apache/hadoop/pull/6177
* coalesce proxy settings between the two clients
* only set async proxy settings if non-empty
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> coalesce AWS S3 client proxy settings
> -------------------------------------
>
> Key: HADOOP-18935
> URL: https://issues.apache.org/jira/browse/HADOOP-18935
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Priority: Major
>
> all the code to build up proxy settings for the two clients is nearly
> identical.
> * coalesce into on method to load all the options, another to apply them to
> the different bullders
> * extend TestS3AProxy to test async client too
> * test for invalid options, rather than just the good paths.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
