zhangshuyan0 commented on code in PR #6176:
URL: https://github.com/apache/hadoop/pull/6176#discussion_r1360327000
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -1819,6 +1820,19 @@ void removeBlocksAssociatedTo(final DatanodeStorageInfo
storageInfo) {
storageInfo, node);
}
+ /** Remove the blocks to the given DatanodeDescriptor from InvalidateBlocks.
*/
+ void removeBlocksFromInvalidateBlocks(final DatanodeDescriptor node) {
+ assert namesystem.hasWriteLock();
+ invalidateBlocks.remove(node);
+ }
+
+ /** Remove the blocks to the given DatanodeDescriptor from
excessRedundancyMap. */
+ LightWeightHashSet<BlockInfo> removeBlocksFromExcessRedundancyMap(
Review Comment:
removeBlocksFromExcessRedundancyMap -> removeNodeFromExcessRedundancyMap
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -1819,6 +1820,19 @@ void removeBlocksAssociatedTo(final DatanodeStorageInfo
storageInfo) {
storageInfo, node);
}
+ /** Remove the blocks to the given DatanodeDescriptor from InvalidateBlocks.
*/
+ void removeBlocksFromInvalidateBlocks(final DatanodeDescriptor node) {
Review Comment:
Suggest modifying the method name:
removeBlocksFromInvalidateBlocks -> removeNodeFromInvalidateBlocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
