ZanderXu commented on code in PR #6043:
URL: https://github.com/apache/hadoop/pull/6043#discussion_r1360473793
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java:
##########
@@ -147,6 +147,8 @@ public static RpcMetrics create(Server server,
Configuration conf) {
MutableCounterLong rpcRequeueCalls;
@Metric("Number of successful RPC calls")
MutableCounterLong rpcCallSuccesses;
+ @Metric("Number of observer namenode rejected RPC calls")
+ MutableCounterLong rpcCallsRejectedByObserver;
Review Comment:
Thanks @haiyang1987 for your report. And thanks @simbadzina @goiri for your
review.
I'm just concern if it's reasonable that `rpcCallsRejectedByObserver` is in
`RpcMetrics.java`. I think `rpcCallsRejectedByObserver` is a logic of
namenode, so how about changing this logic as a HDFS issue, not common issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
