[
https://issues.apache.org/jira/browse/HADOOP-18885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775684#comment-17775684
]
ASF GitHub Bot commented on HADOOP-18885:
-----------------------------------------
ZanderXu commented on code in PR #6043:
URL: https://github.com/apache/hadoop/pull/6043#discussion_r1360473793
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java:
##########
@@ -147,6 +147,8 @@ public static RpcMetrics create(Server server,
Configuration conf) {
MutableCounterLong rpcRequeueCalls;
@Metric("Number of successful RPC calls")
MutableCounterLong rpcCallSuccesses;
+ @Metric("Number of observer namenode rejected RPC calls")
+ MutableCounterLong rpcCallsRejectedByObserver;
Review Comment:
Thanks @haiyang1987 for your report. And thanks @simbadzina @goiri for your
review.
I'm just concern if it's reasonable that `rpcCallsRejectedByObserver` is in
`RpcMetrics.java`. I think `rpcCallsRejectedByObserver` is a logic of
namenode, so how about changing this logic as a HDFS issue, not common issue?
> Add rpcRejectedByObserverCalls metric to quantify the number of rejected
> RPCs by Observer NameNode
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-18885
> URL: https://issues.apache.org/jira/browse/HADOOP-18885
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> When observer Node's serverStateId is too far behind clientStateId will
> rejected client RPC request,
> mabe we need add rpcRejectedByObserverCalls metric to RpcMetrics to quantify
> the number of rejected RPCs by Observer NameNode to help determine how well
> the server.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
