steveloughran commented on code in PR #6202:
URL: https://github.com/apache/hadoop/pull/6202#discussion_r1365370076
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/IAMInstanceCredentialsProvider.java:
##########
@@ -78,23 +117,52 @@ public AwsCredentials resolveCredentials() {
*
* @return credentials
*/
- private AwsCredentials getCredentials() {
+ private synchronized AwsCredentials getCredentials() {
Review Comment:
no, because it was creating and collecting credentials on every call. so if
multiple requests came in, it instantiated new ones and did new HTTP calls.
inefficient and clearl a bit brittle. now we want to only have one instance
which we close() after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
