[
https://issues.apache.org/jira/browse/HADOOP-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777217#comment-17777217
]
ASF GitHub Bot commented on HADOOP-18945:
-----------------------------------------
steveloughran commented on code in PR #6202:
URL: https://github.com/apache/hadoop/pull/6202#discussion_r1365370076
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/IAMInstanceCredentialsProvider.java:
##########
@@ -78,23 +117,52 @@ public AwsCredentials resolveCredentials() {
*
* @return credentials
*/
- private AwsCredentials getCredentials() {
+ private synchronized AwsCredentials getCredentials() {
Review Comment:
no, because it was creating and collecting credentials on every call. so if
multiple requests came in, it instantiated new ones and did new HTTP calls.
inefficient and clearl a bit brittle. now we want to only have one instance
which we close() after
> S3A: IAMInstanceCredentialsProvider failing: Failed to load credentials from
> IMDS
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-18945
> URL: https://issues.apache.org/jira/browse/HADOOP-18945
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 7.2.18.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Blocker
> Labels: pull-request-available
>
> Failures in impala test VMs using iAM for auth
> {code}
> Failed to open file as a parquet file: java.net.SocketTimeoutException:
> re-open
> s3a://impala-test-uswest2-1/test-warehouse/test_pre_gregorian_date_parquet_2e80ae30.db/hive2_pre_gregorian.parquet
> at 84 on
> s3a://impala-test-uswest2-1/test-warehouse/test_pre_gregorian_date_parquet_2e80ae30.db/hive2_pre_gregorian.parquet:
> org.apache.hadoop.fs.s3a.auth.NoAwsCredentialsException: +: Failed to load
> credentials from IMDS
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
