fapifta commented on PR #6194: URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1771845122
@jojochuang @dombizita checking into the failures, I firmly believe that they were failing because in the meantime there was a bump in Zookeeper version, 3.6.3->3.6.4 and after the failures an other one, 3.6.4->3.7.2. 3.6.4 contains ZOOKEEPER-1875, that introduced a null check on the watcher constructor parameter, while this is already reverted in 3.7.2. If @dombizita fixes the checkstyle part, and trigger a new build, I think these issues will go away and tests will pass. On this... I could not figure out why the ZK bump did not triggered test issues, but if we run tests selectively for changes, then we should revisit the selection, and if there are version changes in the hadoop-project module, or anywhere else, we probably should run a full testing and evaluate the errors more carefully, as the 3.6.3-3.6.4 bump should have broke these tests already as I understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
