mccormickt12 commented on code in PR #6198:
URL: https://github.com/apache/hadoop/pull/6198#discussion_r1367808736


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java:
##########
@@ -1919,6 +1933,21 @@ public Collection<? extends BlockStoragePolicySpi> 
getAllStoragePolicies()
       }
       return allPolicies;
     }
+
+    @Override
+    public Path getEnclosingRoot(Path path) throws IOException {
+      InodeTree.ResolveResult<FileSystem> res;
+      try {
+        res = fsState.resolve((path.toString()), true);
+      } catch (FileNotFoundException ex) {
+        throw new NotInMountpointException(path, 
String.format("getEnclosingRoot - %s", ex.getMessage()));

Review Comment:
   im not totally sure what the ask is here, this is how i've been doing all of 
them. Are you saying only have the caught exception as the cause without the 
`getEnclosingRoot - "` part?



##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:
##########
@@ -4944,6 +4944,24 @@ public CompletableFuture<FSDataInputStream> build() 
throws IOException {
 
   }
 
+  /**
+   * Return path of the enclosing root for a given path

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to