[
https://issues.apache.org/jira/browse/HADOOP-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236026#comment-13236026
]
Alejandro Abdelnur commented on HADOOP-7030:
--------------------------------------------
+1 after a few minor corrections:
1. Reader creation simplification:
{code}
File file = new File(filename);
reader = new BufferedReader(new InputStreamReader(new FileInputStream(
file)));
{code}
should be:
{code}
File file = new File(filename);
reader = new BufferedReader(new FileReader(filename));
{code}
2. non-comment & invalid lines (not 2 columns) should write a log warning
instead failing silently.
3. rename refresh() to load() or initialize(). refresh() gives the impression
of well refresh() and I'm not sure this is the intention.
> new topology mapping implementations
> ------------------------------------
>
> Key: HADOOP-7030
> URL: https://issues.apache.org/jira/browse/HADOOP-7030
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Patrick Angeles
> Assignee: Tom White
> Attachments: HADOOP-7030-2.patch, HADOOP-7030.patch,
> HADOOP-7030.patch, HADOOP-7030.patch, topology.patch
>
>
> The default ScriptBasedMapping implementation of DNSToSwitchMapping for
> determining cluster topology has some drawbacks. Principally, it forks to an
> OS-specific script.
> This issue proposes two new Java implementations of DNSToSwitchMapping.
> TableMapping reads a two column text file that maps an IP or hostname to a
> rack ID. Ip4RangeMapping reads a three column text file where each line
> represents a start and end IP range plus a rack ID.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
