ayushtkn commented on code in PR #6227:
URL: https://github.com/apache/hadoop/pull/6227#discussion_r1375504306
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##########
@@ -151,7 +154,7 @@ void recordFailure(final InvalidEncryptionKeyException e)
}
}
- private class StreamerStreams implements java.io.Closeable {
+ private class StreamerStreams implements Closeable {
Review Comment:
unrelated, avoid
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##########
@@ -564,6 +566,34 @@ private DataStreamer(HdfsFileStatus stat, ExtendedBlock
block,
this.addBlockFlags = flags;
this.maxPipelineRecoveryRetries = conf.getMaxPipelineRecoveryRetries();
this.markSlowNodeAsBadNodeThreshold =
conf.getMarkSlowNodeAsBadNodeThreshold();
+ congestionBackOffMeanTimeInMs = dfsClient.getConfiguration().getInt(
+ HdfsClientConfigKeys.DFS_CLIENT_CONGESTION_BACKOFF_MEAN_TIME,
+ HdfsClientConfigKeys.DFS_CLIENT_CONGESTION_BACKOFF_MEAN_TIME_DEFAULT);
+ congestionBackOffMaxTimeInMs = dfsClient.getConfiguration().getInt(
+ HdfsClientConfigKeys.DFS_CLIENT_CONGESTION_BACKOFF_MAX_TIME,
+ HdfsClientConfigKeys.DFS_CLIENT_CONGESTION_BACKOFF_MAX_TIME_DEFAULT);
+ if (congestionBackOffMeanTimeInMs <= 0 || congestionBackOffMaxTimeInMs <=
0 ||
+ congestionBackOffMaxTimeInMs < congestionBackOffMeanTimeInMs) {
+ if (congestionBackOffMeanTimeInMs <= 0) {
+ LOG.warn("Configuration: {} is not appropriate, use default value: {}",
Review Comment:
can you change use to using, here & everywhere
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##########
@@ -1113,7 +1143,7 @@ boolean shouldWaitForRestart(int index) {
InetAddress addr = null;
try {
addr = InetAddress.getByName(nodes[index].getIpAddr());
- } catch (java.net.UnknownHostException e) {
+ } catch (UnknownHostException e) {
Review Comment:
unrelated change, please avoid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
