hiwangzhihui commented on code in PR #6234:
URL: https://github.com/apache/hadoop/pull/6234#discussion_r1375710840
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java:
##########
@@ -1849,8 +1849,8 @@ protected Subject getSubject() {
@InterfaceStability.Evolving
public <T> T doAs(PrivilegedAction<T> action) {
if (LOG.isDebugEnabled()) {
- LOG.debug("PrivilegedAction [as: {}][action: {}]", this, action,
- new Exception());
+ LOG.debug("PrivilegedAction [as: {}][action: {}][from: {}]", this,
action,
+ Thread.currentThread().getStackTrace()[2]);
Review Comment:
Of course, having access to more stack information may be helpful for us in
troubleshooting.
But Before the HADOOP-16691 community’s approach was to adopt this way of
print stack info.
The excessive amount of information currently available is causing
interference with troubleshooting assessment, and it requires us to make a
trade-off.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java:
##########
@@ -1849,8 +1849,8 @@ protected Subject getSubject() {
@InterfaceStability.Evolving
public <T> T doAs(PrivilegedAction<T> action) {
if (LOG.isDebugEnabled()) {
- LOG.debug("PrivilegedAction [as: {}][action: {}]", this, action,
- new Exception());
+ LOG.debug("PrivilegedAction [as: {}][action: {}][from: {}]", this,
action,
+ Thread.currentThread().getStackTrace()[2]);
Review Comment:
Of course, having access to more stack information may be helpful for us in
troubleshooting.
But Before the HADOOP-16691 community’s approach was to adopt this way of
print stack info.
The excessive amount of information currently available is causing
interference with troubleshooting assessment, and it requires us to make a
trade-off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
