[
https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236169#comment-13236169
]
Hadoop QA commented on HADOOP-8159:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519537/HADOOP-8159-b1.007.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/752//console
This message is automatically generated.
> NetworkTopology: getLeaf should check for invalid topologies
> ------------------------------------------------------------
>
> Key: HADOOP-8159
> URL: https://issues.apache.org/jira/browse/HADOOP-8159
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 0.23.3
>
> Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch,
> HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch,
> HADOOP-8159.008.patch, HADOOP-8159.009.patch
>
>
> Currently, in NetworkTopology, getLeaf doesn't do too much validation on the
> InnerNode object itself. This results in us getting ClassCastException
> sometimes when the network topology is invalid. We should have a less
> confusing exception message for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
