haiyang1987 commented on code in PR #6176:
URL: https://github.com/apache/hadoop/pull/6176#discussion_r1384808440
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/ExcessRedundancyMap.java:
##########
@@ -111,4 +113,56 @@ synchronized boolean remove(DatanodeDescriptor dn,
BlockInfo blk) {
}
return removed;
}
+
+ synchronized Map<String, LightWeightHashSet<ExcessBlockInfo>>
getExcessRedundancyMap() {
+ return map;
+ }
+
+ /**
+ * An object that contains information about a block that is being excess
redundancy.
+ * It records the timestamp when added excess redundancy map of this block.
+ */
+ static class ExcessBlockInfo implements Comparable<ExcessBlockInfo> {
+ private long timeStamp;
+ private BlockInfo blockInfo;
+
+ ExcessBlockInfo(BlockInfo blockInfo) {
+ this.timeStamp = monotonicNow();
+ this.blockInfo = blockInfo;
+ }
+
+ public BlockInfo getBlockInfo() {
+ return blockInfo;
+ }
+
+ long getTimeStamp() {
+ return timeStamp;
+ }
+
+ void setTimeStamp() {
+ timeStamp = monotonicNow();
+ }
+
+ @Override
+ public int hashCode() {
+ return blockInfo.hashCode();
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (this == obj) {
+ return true;
+ }
+ if (!(obj instanceof ExcessBlockInfo)) {
+ return false;
+ }
+ ExcessBlockInfo other = (ExcessBlockInfo) obj;
+ return (this.blockInfo.equals(other.blockInfo));
Review Comment:
Sir's suggestion is reasonable. here it's sufficient to just compare
blockInfo, i will fix it to avoid more heap footprint cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
