steveloughran commented on PR #6249:
URL: https://github.com/apache/hadoop/pull/6249#issuecomment-1801983058
having hit this myself, I'm going to say "this PR needss to include the name
passed in rather than just assert true/false"
proposed,
```java
assertValidName(String name) {
assertFalse("Should have been rejected '" + name + "'", isValidName(name);
}
```
...and all asserts in the test case switched over to this. think how much
easier it will be debugging yetus falures the next time there's a regressoin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
