[ 
https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236952#comment-13236952
 ] 

Suresh Srinivas commented on HADOOP-8202:
-----------------------------------------

bq. Also, given that implementing the ProtocolTranslator interface is necessary 
in order for RPC#getServerAddress to work, perhaps a better solution would be 
to leave RPC#stopProxy as it is now, and change the protocol translators that 
currently implement Closeable to instead implement ProtocolTrnaslator.

I want to look at the ProtocolTranslator and why it is needed in detail. In 
this part of the code clearly ProtocolTranslator is not required.
                
> stopproxy() is not closing the proxies correctly
> ------------------------------------------------
>
>                 Key: HADOOP-8202
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8202
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Hari Mankude
>            Assignee: Hari Mankude
>            Priority: Minor
>         Attachments: HADOOP-8202.patch, HADOOP-8202.patch
>
>
> I was running testbackupnode and noticed that NNprotocol proxy was not being 
> closed. Talked with Suresh and he observed that most of the protocols do not 
> implement ProtocolTranslator and hence the logic in stopproxy() does not 
> work. Instead, since all of them are closeable, Suresh suggested that 
> closeable property should be used at close.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to