jojochuang commented on code in PR #6263:
URL: https://github.com/apache/hadoop/pull/6263#discussion_r1393407606
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java:
##########
@@ -297,8 +298,8 @@ public List<HAServiceTarget> getAllOtherNodes() {
@Override
protected boolean isSSLEnabled() {
- return conf.getBoolean(
- DFSConfigKeys.ZK_CLIENT_SSL_ENABLED,
- DFSConfigKeys.DEFAULT_ZK_CLIENT_SSL_ENABLED);
+ return conf.getBoolean(CommonConfigurationKeys.ZK_CLIENT_SSL_ENABLED,
+ conf.getBoolean(DFSConfigKeys.ZK_CLIENT_SSL_ENABLED,
+ DFSConfigKeys.DEFAULT_ZK_CLIENT_SSL_ENABLED));
Review Comment:
This would imply dfs.ha.zkfc.client.ssl.enabled becomes defunct. And perhaps
we should update hdfs-default.xml too.
Why is it different from YARN? In YARN,
yarn.resourcemanager.zk-client-ssl.enabled takes effect if
hadoop.zk.ssl.enabled is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
