goiri commented on code in PR #6265: URL: https://github.com/apache/hadoop/pull/6265#discussion_r1394640065
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java: ########## @@ -1039,6 +1114,54 @@ protected String getUsageString() { return "Usage: rmadmin"; } + /** + * Parse subClusterId. + * This method will only parse subClusterId when Yarn Federation mode is enabled. + * + * @param cliParser CommandLine. + * @return subClusterId. + */ + protected String parseSubClusterId(CommandLine cliParser) { + // If YARN Federation mode is not enabled, return empty. + if (!isYarnFederationEnabled(getConf())) { + return StringUtils.EMPTY; + } + + String subClusterId = cliParser.getOptionValue(OPTION_SUBCLUSTERID); + if(StringUtils.isBlank(subClusterId)) { Review Comment: Space missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org