haiyang1987 commented on PR #6266:
URL: https://github.com/apache/hadoop/pull/6266#issuecomment-1817514156
> qq: which version of hadoop did you run? Does `triggerActiveLogRoll()`
actually try to connect to other NNs as well or only activeNN? Is your issue
happening for trunk? By reading the source code, that does not seem to be the
case: It seems `triggerActiveLogRoll` should only contact activeNN.
>
> log line of "Triggering log rolling to the remote NameNode, ": is this
truncated in your paste? seems to be incomplete compared to trunk.
>
> ```
> /**
> * Trigger the active node to roll its logs.
> */
> @VisibleForTesting
> void triggerActiveLogRoll() {
> Future<Void> future = null;
> try {
> ...
> }
>
> Callable<Void> getNameNodeProxy() {
> return new MultipleNameNodeProxy<Void>() {
> @Override
> protected Void doWork() throws IOException {
> LOG.info("Triggering log rolling to the remote NameNode, " +
> "active NameNode = {}", currentNN.getIpcAddress());
> cachedActiveProxy.rollEditLog();
> return null;
> }
> };
> ```
Thanks @xinglin for your comment.
The current version is hadoop 3.3, triggerActiveLogRoll() will actually try
to connect to other NNs until active nn is requested, and recorded as
cachedActiveProxy
for this log
```
LOG.info("Triggering log rolling to the remote NameNode, " + "active
NameNode = {}", currentNN.getIpcAddress());
```
It is from by PR: HDFS-1630, it only record the remote NameNode address in
logs. this PR is not introduced in our current version.
trunk branch still has the problem described in the current issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
