susheel-gupta commented on code in PR #5317:
URL: https://github.com/apache/hadoop/pull/5317#discussion_r1403154800
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java:
##########
@@ -456,6 +456,19 @@ public int getActiveRMIndex() {
return -1;
}
+ /**
+ * Stopping MiniYarnCluster can take more than 30 seconds and it's a
blocking operation so it blocks test execution,
+ * so to prevent that we can stop the cluster asynchronously,
+ * that can ultimately save test execution time.
+ * @param owner the Test class that owns the instance of MiniYarnCluster
+ */
+ public void asyncStop(Object owner) {
Review Comment:
Each mini cluster is taking 40-55 secs to be stopped. As per your comment
and the code, async is an inappropriate choice so updated with sync stopping
of Mini cluster.
Thanks @tomicooler for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
