goiri commented on code in PR #6288:
URL: https://github.com/apache/hadoop/pull/6288#discussion_r1405472293
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -2188,11 +2188,12 @@ private static FsPermission getParentPermission(final
FsPermission mask) {
* @param name Name of the mount point.
* @param childrenNum Number of children.
* @param date Map with the dates.
+ * @param setPath if true should set path in HdfsFileStatus
* @return New HDFS file status representing a mount point.
*/
@VisibleForTesting
HdfsFileStatus getMountPointStatus(
- String name, int childrenNum, long date) {
+ String name, int childrenNum, long date, boolean setPath) {
Review Comment:
I'm just saying that you can keep the old method and call whicheves is the
default value:
```
HdfsFileStatus getMountPointStatus(
String name, int childrenNum, long date) {
return getMountPointStatus(name, childrenNum, date);
}
```
Then you don't need to modify that many other pieces of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
