huangzhaobo99 commented on code in PR #6279:
URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412774811
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java:
##########
@@ -46,11 +46,6 @@ public class SlowPeerDisabledTracker extends SlowPeerTracker
{
public SlowPeerDisabledTracker(Configuration conf, Timer timer) {
super(conf, timer);
- final boolean dataNodePeerStatsEnabledVal =
- conf.getBoolean(DFSConfigKeys.DFS_DATANODE_PEER_STATS_ENABLED_KEY,
- DFSConfigKeys.DFS_DATANODE_PEER_STATS_ENABLED_DEFAULT);
- Preconditions.checkArgument(!dataNodePeerStatsEnabledVal,
- "SlowPeerDisabledTracker should only be used for disabled slow peer
stats.");
Review Comment:
Sorry, I just understood what you mean. This is very nice.
In addition, I will replace the nameNode.reconfigurePropertyImpl used in
testSlowPeerTrackerEnable UT with nameNode.reconfigurePropertyImpl, which is
more in line with the production env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
