[ 
https://issues.apache.org/jira/browse/HADOOP-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793038#comment-17793038
 ] 

ASF GitHub Bot commented on HADOOP-18981:
-----------------------------------------

xinglin commented on PR #6280:
URL: https://github.com/apache/hadoop/pull/6280#issuecomment-1839519151

   The key point is if we use UDPClient/server from other module, then it 
becomes inappropriate to put this under hadoop-common-project/hadoop-nfs 
module. And if we don't fix it now but build upon this, it would make code 
harder to maintain and would take more work if we want to fix it in the future. 
   
   Another example is the key-value Interface/implementation. Right now, YARN 
uses a key-value store to store some persistent data and they put key-value 
interface/implementation in YARN module. However, we may look into store 
persistent k/v pairs too for HDFS. We should move key-value 
interface/implemention into hadoop-common, rather than adding a dependency on 
YARN from HDFS.
   
   I still remember a lesson I learned from reading John Ousterhout's "a 
philosophy of software engineering" book: when we make a change to an existing 
system, we should make the new change such that the new change seems to be 
designed from the beginning. On the other hand, most of us tend to try 
minimizing line of changes, which ideally shouldn't not be a concern. 




> Move oncrpc/portmap from hadoop-nfs to hadoop-common
> ----------------------------------------------------
>
>                 Key: HADOOP-18981
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18981
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.4.0
>            Reporter: Xing Lin
>            Assignee: Xing Lin
>            Priority: Major
>              Labels: pull-request-available
>
> We want to use udpserver/client for other use cases, rather than only for 
> NFS. One such use case is to export NameNodeHAState for NameNodes via a UDP 
> server. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to