hfutatzhanghb commented on code in PR #6321:
URL: https://github.com/apache/hadoop/pull/6321#discussion_r1419950588
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##########
@@ -934,14 +936,14 @@ void waitForAckedSeqno(long seqno) throws IOException {
}
try {
dataQueue.wait(1000); // when we receive an ack, we notify on
- long duration = Time.monotonicNow() - begin;
- if (duration > writeTimeout) {
+ long duration = Time.monotonicNowNanos() - begin;
Review Comment:
> Get it , thanks @hfutatzhanghb comment.
>
> ```
> if (TimeUnit.NANOSECONDS.toMillis(duration) > writeTimeout) {
> LOG.error("No ack received, took {}ms (threshold={}ms). "
> + "File being written: {}, block: {}, "
> + "Write pipeline datanodes: {}.",
> TimeUnit.NANOSECONDS.toMillis(duration), writeTimeout, src, block,
nodes);
> throw new InterruptedIOException("No ack received after " +
> TimeUnit.NANOSECONDS.toSeconds(duration) + "s and a timeout of " +
> TimeUnit.MILLISECONDS.toSeconds(writeTimeout) + "s");
> }
> ```
>
> how about it?
@hfutatzhanghb Sir, thanks a lot for your reviewing, you are welcome. This
part i did not use nanosecond as unit because i think printing error logs using
nanosecond is not very intuitive, So I keep it the way it was. As this PR's
title described, its goal is for better debugging. Of course，it can be
nanosecond, we can here other peoples' thoughts. Thanks again.
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##########
@@ -934,14 +936,14 @@ void waitForAckedSeqno(long seqno) throws IOException {
}
try {
dataQueue.wait(1000); // when we receive an ack, we notify on
- long duration = Time.monotonicNow() - begin;
- if (duration > writeTimeout) {
+ long duration = Time.monotonicNowNanos() - begin;
Review Comment:
> Get it , thanks @hfutatzhanghb comment.
>
> ```
> if (TimeUnit.NANOSECONDS.toMillis(duration) > writeTimeout) {
> LOG.error("No ack received, took {}ms (threshold={}ms). "
> + "File being written: {}, block: {}, "
> + "Write pipeline datanodes: {}.",
> TimeUnit.NANOSECONDS.toMillis(duration), writeTimeout, src, block,
nodes);
> throw new InterruptedIOException("No ack received after " +
> TimeUnit.NANOSECONDS.toSeconds(duration) + "s and a timeout of " +
> TimeUnit.MILLISECONDS.toSeconds(writeTimeout) + "s");
> }
> ```
>
> how about it?
@hfutatzhanghb Sir, thanks a lot for your reviewing, you are welcome. This
part i did not use nanosecond as unit because i think printing error logs using
nanosecond is not very intuitive, So I keep it the way it was. As this PR's
title described, its goal is for better debugging. Of course，it can be
nanosecond, we can here other peoples' thoughts. Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
