ayushtkn commented on code in PR #6338:
URL: https://github.com/apache/hadoop/pull/6338#discussion_r1424015908
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java:
##########
@@ -522,4 +523,10 @@ public void setOutliersReportIntervalMs(String
reportIntervalMs) {
DFS_DATANODE_OUTLIERS_REPORT_INTERVAL_KEY,
DFS_DATANODE_OUTLIERS_REPORT_INTERVAL_DEFAULT, TimeUnit.MILLISECONDS);
}
+
+ public void setDatanodeSlowIoWarningThresholdMs(long threshold) {
+ Preconditions.checkArgument(threshold > 0,
+ DFS_DATANODE_SLOW_IO_WARNING_THRESHOLD_KEY + " should be larger than
0");
Review Comment:
nit
should be greater than
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -1056,6 +1061,25 @@ private String reconfDiskBalancerParameters(String
property, String newVal)
}
}
+ private String reconfSlowIoWarningThresholdParameters(String property,
+ String newVal) throws ReconfigurationException {
Review Comment:
your code isn't formatted properly I believe, the line wrap is at 100
```
private String reconfSlowIoWarningThresholdParameters(String property,
String newVal)
throws ReconfigurationException {
```
can use the hadoop formatter if you need & if you use intelliJ
https://github.com/apache/hadoop/blob/trunk/dev-support/code-formatter/hadoop_idea_formatter.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
