[
https://issues.apache.org/jira/browse/HADOOP-19011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796905#comment-17796905
]
ASF GitHub Bot commented on HADOOP-19011:
-----------------------------------------
hadoop-yetus commented on PR #6358:
URL: https://github.com/apache/hadoop/pull/6358#issuecomment-1856583954
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 6m 36s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ branch-3.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 46m 22s | | branch-3.3 passed |
| +1 :green_heart: | compile | 0m 25s | | branch-3.3 passed |
| +1 :green_heart: | checkstyle | 0m 25s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 0m 29s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 0m 29s | | branch-3.3 passed |
| +1 :green_heart: | spotbugs | 0m 46s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 34m 36s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 20s | | the patch passed |
| +1 :green_heart: | compile | 0m 17s | | the patch passed |
| +1 :green_heart: | javac | 0m 17s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 13s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 20s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 17s | | the patch passed |
| +1 :green_heart: | spotbugs | 0m 44s | | the patch passed |
| +1 :green_heart: | shadedclient | 34m 8s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 22s | | hadoop-maven-plugins in the
patch passed. |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not
generate ASF License warnings. |
| | | 130m 58s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6358/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6358 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 55ab2ab141c0 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / 4f1b82d171c6148eaf3cc1857b153fee6cfa3867 |
| Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6358/1/testReport/ |
| Max. process+thread count | 674 (vs. ulimit of 5500) |
| modules | C: hadoop-maven-plugins U: hadoop-maven-plugins |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6358/1/console |
| versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Possible ConcurrentModificationException if Exec command fails
> --------------------------------------------------------------
>
> Key: HADOOP-19011
> URL: https://issues.apache.org/jira/browse/HADOOP-19011
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> {{ConcurrentModificationException}} may happen in:
> {code:title=https://github.com/apache/hadoop/blob/19b9e6a97b8faa0eb48e7b1855ab37e6d4b6c2a9/hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/util/Exec.java#L64-L82}
> public int run(List<String> command, List<String> output,
> List<String> errors) {
> int retCode = 1;
> ProcessBuilder pb = new ProcessBuilder(command);
> try {
> Process p = pb.start();
> OutputBufferThread stdOut = new OutputBufferThread(p.getInputStream());
> OutputBufferThread stdErr = new OutputBufferThread(p.getErrorStream());
> stdOut.start();
> stdErr.start();
> retCode = p.waitFor();
> if (retCode != 0) {
> mojo.getLog().warn(command + " failed with error code " + retCode);
> for (String s : stdErr.getOutput()) {
> mojo.getLog().debug(s);
> }
> }
> stdOut.join();
> stdErr.join();
> {code}
> due to accessing {{stdErr.getOutput()}} before {{stdErr}} thread stops.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
