simbadzina commented on code in PR #6359:
URL: https://github.com/apache/hadoop/pull/6359#discussion_r1430796400
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java:
##########
@@ -342,6 +344,14 @@ public void incrClientBackoff() {
rpcClientBackoff.incr();
}
+ /**
+ * Client was backoff due to disconnection
Review Comment:
Is this the other way around, the client ended up being disconnected due to
backoffs?
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -3133,6 +3133,13 @@ private void internalQueueCall(Call call, boolean
blocking)
// For example, IPC clients using FailoverOnNetworkExceptionRetry handle
// RetriableException.
rpcMetrics.incrClientBackoff();
+ // Clients that are directly put into lowest priority queue are backoff
and disconnected.
Review Comment:
Nit-> tense. backed off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
