K0K0V0K commented on code in PR #6371:
URL: https://github.com/apache/hadoop/pull/6371#discussion_r1431687597
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java:
##########
@@ -78,6 +78,7 @@ public void setup() {
conf.setBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, true);
conf.setFloat(YarnConfiguration.TIMELINE_SERVICE_VERSION, 1.0f);
client = createTimelineClient(conf);
+ TimelineConnector.DEFAULT_SOCKET_TIMEOUT = 10;
Review Comment:
well... it is a good question that made me wonder in case of a successful
connection how long the KerberosAuthenticator#190 connect is running, and the
plot-twist i just realized all of the tests expect timeout here 😅
If you add a some debug point before and after this line we can observe the
debug point after the connect will never be triggered, so technically we can
also write 1ms here, the tests can not be broken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
