ayushtkn commented on code in PR #6307:
URL: https://github.com/apache/hadoop/pull/6307#discussion_r1431732773
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/DatanodeHttpServer.java:
##########
@@ -144,7 +146,9 @@ public DatanodeHttpServer(final Configuration conf,
confForCreate.set(FsPermission.UMASK_LABEL, "000");
this.bossGroup = new NioEventLoopGroup();
- this.workerGroup = new NioEventLoopGroup();
+ int workerThreads = conf.getInt(DFS_DATANODE_NETTY_WORKER_NUM_THREADS_KEY,
+ DFS_DATANODE_NETTY_WORKER_NUM_THREADS_DEFAULT);
Review Comment:
Should validate this value, for -ve values, if it is -ve we should put a
warn log & use default.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml:
##########
@@ -154,6 +154,14 @@
</description>
</property>
+<property>
+ <name>dfs.datanode.netty.worker.threads</name>
+ <value>10</value>
Review Comment:
Shouldn't the default be 0, to preserve the original behaviour, earlier we
were passing 0 internally here?
```
this.workerGroup = new NioEventLoopGroup();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
