hfutatzhanghb commented on code in PR #6377: URL: https://github.com/apache/hadoop/pull/6377#discussion_r1437336878
########## hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md: ########## @@ -425,6 +425,12 @@ Each metrics record contains tags such as SessionId and Hostname as additional i | `RamDiskBlocksLazyPersistWindows`*num*`s(50/75/90/95/99)thPercentileLatency` | The 50/75/90/95/99th percentile of latency between memory write and disk persist in milliseconds (*num* seconds granularity). Percentile measurement is off by default, by watching no intervals. The intervals are specified by `dfs.metrics.percentiles.intervals`. | | `FsyncCount` | Total number of fsync | | `VolumeFailures` | Total number of volume failures occurred | +| `DatanodeNetworkErrors` | Count of network errors on the datanode | Review Comment: Hi~ @huangzhaobo99 . The goal of this PR is just to add read and write dataXceiver threads count metrics. But DataNodePacketResponderCount、DataNodeBlockRecoveryWorkerCount is not related with it. You can propose an another PR to add them. Just my opinions, Thanks for you replying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
