hiwangzhihui commented on code in PR #6352:
URL: https://github.com/apache/hadoop/pull/6352#discussion_r1438289028
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java:
##########
@@ -1118,38 +1124,25 @@ protected void serviceStop() throws Exception {
}
}
- /**
Review Comment:
The SotopBug warning is to expect RMFatalToStandbyRunner to submit and wait
for its execution result.
If waiting for the execution result synchronously results in a "cyclic
dependency" issue;
However, in the call method of TransitionToActiveStandbyRunnern, both
execution results and exceptions have been uniformly processed and log printed.
The RMFatalToStandbyRunner execution results only have two results: ①
successful execution ② Execution exception failed, RM process exited.
My opinion is this warning can be ignored in this scene, As adding a thread
to wait for the result would be redundant.
@slfan1989 How does view and handle this warning? I would like to hear your
opinion again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
