huangzhaobo99 commented on code in PR #6323:
URL: https://github.com/apache/hadoop/pull/6323#discussion_r1438904713
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -1423,9 +1420,7 @@ private static boolean format(Configuration conf, boolean
force,
LOG.warn("Encountered exception during format", ioe);
throw ioe;
} finally {
- if (fsImage != null) {
- fsImage.close();
- }
+ fsImage.close();
Review Comment:
Happy New Year, Everybody!
Leave some minor opinions, we can use the try-with-resources.
there are still some invalid variables that cause some warnings in the test
report, If necessary, I can optimize it here. cc @tasanuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
