ashutoshcipher commented on code in PR #6394:
URL: https://github.com/apache/hadoop/pull/6394#discussion_r1438938088
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java:
##########
@@ -598,7 +599,9 @@ private int receivePacket() throws IOException {
return 0;
}
- datanode.metrics.incrPacketsReceived();
Review Comment:
I see you've updated it to increment packetsReceived only when seqno is not
HEART_BEAT_SEQNO. This is a critical change for accurately tracking packets.
However, it would be helpful to add a comment here explaining why heartbeats
are excluded from this metric for clarity and future reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
