steveloughran commented on code in PR #6373:
URL: https://github.com/apache/hadoop/pull/6373#discussion_r1439080434
##########
hadoop-yarn-project/pom.xml:
##########
@@ -90,6 +91,56 @@
<artifactId>hadoop-yarn-applications-catalog-webapp</artifactId>
<type>war</type>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
Review Comment:
shouldn't all these be scoped as provided?
##########
hadoop-yarn-project/pom.xml:
##########
@@ -90,6 +91,56 @@
<artifactId>hadoop-yarn-applications-catalog-webapp</artifactId>
<type>war</type>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-yarn-applications-distributedshell</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-yarn-applications-unmanaged-am-launcher</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-yarn-server-tests</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-yarn-server-timelineservice-hbase-client</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
Review Comment:
this worries me. why is this exclusion needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
